Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #486

wants to merge 2 commits into from

Conversation

ochernous
Copy link

No description provided.

OleksandrMoroz24
OleksandrMoroz24 approved these changes Sep 6, 2023
View reviewed changes
Copy link

@OleksandrMoroz24 OleksandrMoroz24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sofbog
Sofbog suggested changes Sep 7, 2023
View reviewed changes
app/managers.py Outdated

class ActorManager:
def __init__(self) -> None:
self._connection = sqlite3.connect("cinema")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected database name with a file extension

app/managers.py Outdated
Comment on lines 41 to 42
f"DELETE FROM {self.table_name}"
"WHERE id = ?", (id_to_delete,)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check syntax of DB query, now it has error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serhii-Leonenko Serhii-Leonenko Serhii-Leonenko approved these changes

@OleksandrMoroz24 OleksandrMoroz24 OleksandrMoroz24 approved these changes

@Sofbog Sofbog Awaiting requested review from Sofbog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ochernous @Sofbog @Serhii-Leonenko @OleksandrMoroz24